Merge pull request #30684 from hashicorp/alisdair/fix-sum-func

functions: Fix sum() of all strings
hashicorp · Mar 16, 2022 · 0bf4112 · 0bf4112
2 parents 3727191 + 0764726
commit 0bf4112
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 0 deletions.
diff --git a/internal/lang/funcs/collection.go b/internal/lang/funcs/collection.go
@@ -527,6 +527,10 @@ var SumFunc = function.New(&function.Spec{
 		if s.IsNull() {
 			return cty.NilVal, function.NewArgErrorf(0, "argument must be list, set, or tuple of number values")
 		}
+		s, err = convert.Convert(s, cty.Number)
+		if err != nil {
+			return cty.NilVal, function.NewArgErrorf(0, "argument must be list, set, or tuple of number values")
+		}
 		for _, v := range arg[1:] {
 			if v.IsNull() {
 				return cty.NilVal, function.NewArgErrorf(0, "argument must be list, set, or tuple of number values")

diff --git a/internal/lang/funcs/collection_test.go b/internal/lang/funcs/collection_test.go
@@ -1629,6 +1629,15 @@ func TestSum(t *testing.T) {
 			cty.NilVal,
 			"can't compute sum of opposing infinities",
 		},
+		{
+			cty.ListVal([]cty.Value{
+				cty.StringVal("1"),
+				cty.StringVal("2"),
+				cty.StringVal("3"),
+			}),
+			cty.NumberIntVal(6),
+			"",
+		},
 	}
 
 	for _, test := range tests {