test fixes

internal/command/views/json/diagnostic.go

@@ -38,7 +38,7 @@ type Diagnostic struct {
 	Address  string             `json:"address,omitempty"`
 	Range    *DiagnosticRange   `json:"range,omitempty"`
 	Snippet  *DiagnosticSnippet `json:"snippet,omitempty"`
-	Extra    interface{}        `json:"extra"`
+	Extra    interface{}        `json:"extra,omitempty"`
 }
 
 // Pos represents a position in the source code.

internal/command/views/json/diagnostic_test.go

@@ -447,6 +447,7 @@ func TestNewDiagnostic(t *testing.T) {
 						},
 					},
 				},
+				Extra: diagnosticCausedBySensitive(true),
 			},
 		},
 		"error with source code subject and expression referring to sensitive value when not caused by sensitive values": {
@@ -616,6 +617,7 @@ func TestNewDiagnostic(t *testing.T) {
 						},
 					},
 				},
+				Extra: diagnosticCausedByUnknown(true),
 			},
 		},
 		"error with source code subject and unknown expression of unknown type": {
@@ -674,6 +676,7 @@ func TestNewDiagnostic(t *testing.T) {
 						},
 					},
 				},
+				Extra: diagnosticCausedByUnknown(true),
 			},
 		},
 		"error with source code subject and unknown expression of unknown type when not caused by unknown values": {
@@ -865,6 +868,7 @@ func TestNewDiagnostic(t *testing.T) {
 						},
 					},
 				},
+				Extra: diagnosticCausedBySensitive(true),
 			},
 		},
 	}

internal/command/views/json/testdata/diagnostic/error-with-source-code-subject-and-expression-referring-to-sensitive-value.json

@@ -27,5 +27,6 @@
         "statement": "has a sensitive value"
       }
     ]
-  }
-}
+  },
+  "extra": true
+}

internal/command/views/json/testdata/diagnostic/error-with-source-code-subject-and-unknown-expression-of-unknown-type.json

@@ -27,5 +27,6 @@
         "statement": "will be known only after apply"
       }
     ]
-  }
-}
+  },
+  "extra": true
+}

internal/command/views/json/testdata/diagnostic/error-with-source-code-subject-and-unknown-string-expression.json

@@ -27,5 +27,6 @@
         "statement": "is a string, known only after apply"
       }
     ]
-  }
-}
+  },
+  "extra": true
+}

internal/command/views/json/testdata/diagnostic/error-with-source-code-subject-with-multiple-expression-values.json

@@ -67,5 +67,6 @@
         "statement": "is object with 2 attributes"
       }
     ]
-  }
-}
+  },
+  "extra": true
+}

internal/configs/module_deprecations.go

@@ -28,6 +28,9 @@ type ModuleDeprecationDiagnosticExtra struct {
 }
 
 func (i *WorkspaceDeprecationInfo) HasDeprecations() bool {
+	if i == nil || i.ModuleDeprecationInfos == nil {
+		return false
+	}
 	for _, deprecationInfo := range i.ModuleDeprecationInfos {
 		if deprecationInfo != nil && deprecationInfo.hasDeprecations() {
 			return true