Add tests for code coverage (configs)

hashicorp · May 29, 2020 · 777d505 · 777d505
1 parent c4a87eb
commit 777d505
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/configs/testdata/invalid-files/variable-validation-error-msg-badref.tf b/configs/testdata/invalid-files/variable-validation-error-msg-badref.tf
@@ -0,0 +1,12 @@
+
+locals {
+  foo = 1
+}
+
+variable "validation" {
+  default = 1
+  validation {
+    condition     = var.validation == 1
+    error_message = "Must be ${local.foo}." # ERROR: Invalid reference in variable validation
+  }
+}
diff --git a/terraform/eval_variable.go b/terraform/eval_variable.go
@@ -211,7 +211,7 @@ func (n *evalVariableValidations) Eval(ctx EvalContext) (interface{}, error) {
 			diags = diags.Append(&hcl.Diagnostic{
 				Severity:    hcl.DiagError,
 				Summary:     errInvalidCondition,
-				Detail:      "Validation condition expression must return either true or false, not null.",
+				Detail:      "Validation error message expression must return a string, not null.",
 				Subject:     validation.ErrorMessage.Range().Ptr(),
 				Expression:  validation.ErrorMessage,
 				EvalContext: hclCtx,