Account for NestedType in static traversal validation
#31532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbardin
added
the
1.2-backport
jbardin
force-pushed
the
jbardin/static-validate-nested-types
branch
from
5e36d3a
to
b267e2d
Compare
|
We have some additional confirmation that this change resolves the configuration issue: hashicorp/terraform-plugin-framework#412 (comment) 😄 |
The StaticValidateTraversal code was not taking into account nested structural types. Rather than create more special cases for checking Type vs NestedType, we move the ImpliedType method up to the Attribute to ensure both are used to generate the final type spec.
jbardin
force-pushed
the
jbardin/static-validate-nested-types
branch
from
b267e2d
to
fd76846
Compare
kmoe
approved these changes
Aug 9, 2022
alisdair
approved these changes
Aug 9, 2022
|
Reminder for the merging maintainer: if this is a user-visible change, please update the changelog on the appropriate release branch. |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were a couple locations left which assumed that a schema
Attributetype was only defined by theTypefield, which would end up using an invalidcty.NilTypewhenNestedTypewas defined. AddImpliedType()to theAttributetype which checks for bothTypeandNestedTypeand use it in place of directTypefield references.Leave the
Object.ImpliedTypemethod for now, sinceobjchangedoes specifically split out theNestedTypefor validation of optional attributes.Fixes #31527