Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of Account for NestedType in static traversal validation into v1.2 #31603

Conversation

teamterraform
Copy link
Contributor

Backport

This PR is auto-generated from #31532 to be assessed for backporting due to the inclusion of the label 1.2-backport.

The below text is copied from the body of the original PR.


There were a couple locations left which assumed that a schema Attribute type was only defined by the Type field, which would end up using an invalid cty.NilType when NestedType was defined. Add ImpliedType() to the Attribute type which checks for both Type and NestedType and use it in place of direct Type field references.

Leave the Object.ImpliedType method for now, since objchange does specifically split out the NestedType for validation of optional attributes.

Fixes #31527

@teamterraform teamterraform force-pushed the backport/jbardin/static-validate-nested-types/possibly-crack-mouse branch 2 times, most recently from c2ef600 to c886582 Compare August 9, 2022 15:08
@teamterraform teamterraform force-pushed the backport/jbardin/static-validate-nested-types/possibly-crack-mouse branch from 12556b0 to 1cb65f6 Compare August 9, 2022 15:08
@jbardin jbardin merged commit c135705 into v1.2 Aug 9, 2022
@github-actions
Copy link

github-actions bot commented Aug 9, 2022

Reminder for the merging maintainer: if this is a user-visible change, please update the changelog on the appropriate release branch.

@github-actions
Copy link

github-actions bot commented Sep 9, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants