Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

account for noop deposed instances in json plan #28922

Merged
merged 1 commit into from
Jun 10, 2021

Conversation

jbardin
Copy link
Member

@jbardin jbardin commented Jun 10, 2021

When rendering a json plan, we need to account for deposed instances
that have become a noop rather than a destroy.

Fixes #28903

When rendering a json plan, we need to account for deposed instances
that have become a noop rather than a destroy.
@jbardin jbardin added the 1.0-backport If you add this label to a PR before merging, backport-assistant will open a new PR once merged label Jun 10, 2021
@jbardin jbardin requested a review from a team June 10, 2021 12:57
@jbardin jbardin merged commit 3296ee2 into main Jun 10, 2021
@jbardin jbardin deleted the jbardin/noop-deposed-change branch June 10, 2021 13:30
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
1.0-backport If you add this label to a PR before merging, backport-assistant will open a new PR once merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Terraform crashing on terraform show -json plan.cache
2 participants