Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add provider mapping to json output of module - fixes issue #30113 #30284

Closed
wants to merge 1 commit into from

Conversation

DaKaZ
Copy link

@DaKaZ DaKaZ commented Jan 3, 2022

This PR adds the provider mappings to the JSON output a module to resolve issue #30113

@hashicorp-cla
Copy link

hashicorp-cla commented Jan 3, 2022

CLA assistant check
All committers have signed the CLA.

@alisdair
Copy link
Member

alisdair commented Jan 4, 2022

Hi @DaKaZ, thanks for contributing this. It's essentially identical to my own draft PR at #30138, so I'd lean towards closing this rather than asking you to update the tests and documentation.

We'll need to confirm with other stakeholders that this change makes sense before proceeding, which is underway now. I'll post updates on the linked issue as I know more. Thanks again!

@DaKaZ
Copy link
Author

DaKaZ commented Jan 4, 2022

@alisdair that is great, thanks, I really don't care who gets the PR as long as it gets landed.

@crw
Copy link
Collaborator

crw commented Jan 6, 2022

Per the comments, closing this PR. Thanks for the contribution!

@crw crw closed this Jan 6, 2022
@github-actions
Copy link

github-actions bot commented Feb 6, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants