Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle null variable input with nullable=false #30330

Merged
merged 1 commit into from Jan 11, 2022
Merged

Handle null variable input with nullable=false #30330

merged 1 commit into from Jan 11, 2022

Commits on Jan 10, 2022

  1. Handle null variable input with nullable=false 

    Default values are currently being handled in two places, the graph
transformation where a synthetic default expression is created if there
was no input expression, and in the evaluator when a reference to the
variable is evaluated. Unfortunately neither of these covers the case
where a non-nullable variable default needs to be checked within a
validation statement

Rather than try and fix the overall variable handling here, which runs
the risk of encountering more unexpected behavior, we are going to fixup
this one case to ensure a null value doesn't continue to slip into
validation. A more extensive refactoring of variable handling has been
completed in v1.2, and this code will only be relevant for the v1.1
branch.
    @jbardin
    jbardin committed Jan 10, 2022
    Configuration menu
    Copy the full SHA
    9314063 View commit details
    Browse the repository at this point in the history