Always use token in backend config when provided

[tangentspace]

This allows overriding a token included in a .terraformrc file by providing a different token in the config block for a terraform_remote_state data source.

Resolves #30664

[hashicorp-cla]

All committers have signed the CLA.

[crw]

Thanks for the submission!

[sebasslash]

Wondering if these changes should also be applied here?

terraform/internal/cloud/backend.go

Lines 217 to 234 in 3fbedf2

	token, err := b.token()
	if err != nil {
	diags = diags.Append(tfdiags.AttributeValue(
	tfdiags.Error,
	strings.ToUpper(err.Error()[:1])+err.Error()[1:],
	"", // no description is needed here, the error is clear
	cty.Path{cty.GetAttrStep{Name: "hostname"}},
	))
	return diags
	}
	// Get the token from the config if no token was configured for this
	// host in credentials section of the CLI Config File.
	if token == "" {
	if val := obj.GetAttr("token"); !val.IsNull() {
	token = val.AsString()
	}
	}

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.