Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli: Fix double-quoted map keys in diff UI #30855

Merged
merged 1 commit into from Apr 13, 2022

Commits on Apr 13, 2022

  1. cli: Fix double-quoted map keys in diff UI

    A previous change added missing quoting around object keys which do not
    parse as barewords. At the same time we introduced a bug where map keys
    could be double-quoted, due to calling the `displayAttributeName` helper
    function (to quote non-bareword keys) then using the `writeValue` method
    (which quotes all strings).
    
    This commit fixes this and adds test coverage for map keys which require
    quoting.
    alisdair committed Apr 13, 2022
    Copy the full SHA
    fadcaaa View commit details
    Browse the repository at this point in the history