Backport of cli: Fix double-quoted map keys in diff UI into v1.1 #30860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teamterraform
force-pushed
the
backport/alisdair/fix-diff-map-key-quoting/intensely-apt-buck
branch
from
1fbda68
to
e8f52d9
Compare
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/hashicorp/terraform/5wpDE1DTPdazm4GRYFRUZr5JAX72 |
alisdair
deleted the
backport/alisdair/fix-diff-map-key-quoting/intensely-apt-buck
branch
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #30855 to be assessed for backporting due to the inclusion of the label 1.1-backport.
The below text is copied from the body of the original PR.
A previous change added missing quoting around object keys which do not parse as barewords. At the same time we introduced a bug where map keys could be double-quoted, due to calling the
displayAttributeNamehelper function (to quote non-bareword keys) then using thewriteValuemethod (which quotes all strings).This commit fixes this and adds test coverage for map keys which require quoting.
Fixes #30854