Backport of data schema changes may prevent state decoding into v1.1 #30871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/hashicorp/terraform/4HNWrYAN193RHagGvEMFGd7e2YiU |
|
|
Data sources do not have state migrations, so there may be no way to decode the prior state when faced with incompatible type changes. Because prior state is only informational to the plan, and its existence should not effect the planning process, we can skip decoding when faced with errors.
jbardin
force-pushed
the
backport/jbardin/data-schema-change/jolly-saved-squid
branch
from
4a643a5
to
7bdbb14
Compare
jbardin
deleted the
backport/jbardin/data-schema-change/jolly-saved-squid
branch
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #30830 to be assessed for backporting due to the inclusion of the label 1.1-backport.
Data sources do not have state migrations, so there may be no way to
decode the prior state when faced with incompatible type changes.
Because prior state is only informational to the plan, and its existence
should not effect the planning process, we can skip decoding when faced
with errors.
This PR intended for backporting avoids the error, however we probably don't need to deal with the prior state at all. I can follow-up with a more invasive PR to remove the extra state handling entirely for v1.2.
Fixes #30823