Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: Report reason for deferring data read until apply #30971

Merged
merged 1 commit into from May 9, 2022

Commits on Apr 30, 2022

  1. core: Report reason for deferring data read until apply

    We have two different reasons why a data resource might be read only
    during apply, rather than during planning as usual: the configuration
    contains unknown values, or the data resource as a whole depends on a
    managed resource which itself has a change pending.
    
    However, we didn't previously distinguish these two in a way that allowed
    the UI to describe the difference, and so we confusingly reported both
    as "config refers to values not yet known", which in turn led to a number
    of reasonable questions about why Terraform was claiming that but then
    immediately below showing the configuration entirely known.
    
    Now we'll use our existing "ActionReason" mechanism to tell the UI layer
    which of the two reasons applies to a particular data resource instance.
    The "dependency pending" situation tends to happen in conjunction with
    "config unknown", so we'll prefer to refer that the configuration is
    unknown if both are true.
    apparentlymart committed Apr 30, 2022
    Copy the full SHA
    95d43c9 View commit details
    Browse the repository at this point in the history