Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of plugin: diagnostics must be checked on all schema calls into v1.2 #30997

Merged

Conversation

teamterraform
Copy link
Contributor

Backport

This PR is auto-generated from #30987 to be assessed for backporting due to the inclusion of the label 1.2-backport.

The below text is copied from the body of the original PR.


We can no longer be assured that the particular instance of a provider we are using has had GetProviderSchema called, so the diagnostics may not have been previously checked. Always check the diagnostics, even if we're fetching a cached response, in order to provide a more meaningful error instead of a panic in the rare case where the rpc call failed.

Fixes #30655

@teamterraform teamterraform requested a review from jbardin May 4, 2022 15:19
@teamterraform teamterraform force-pushed the backport/jbardin/get-schema-diags/clearly-heroic-bedbug branch from a8fa584 to 8d6a665 Compare May 4, 2022 15:19
@jbardin jbardin merged commit 1784778 into v1.2 May 4, 2022
@jbardin jbardin deleted the backport/jbardin/get-schema-diags/clearly-heroic-bedbug branch May 4, 2022 15:34
@github-actions
Copy link

github-actions bot commented May 4, 2022

Reminder for the merging maintainer: if this is a user-visible change, please update the changelog on the appropriate release branch.

@github-actions
Copy link

github-actions bot commented Jun 4, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants