Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport of build: Further polishing of the prototype build workflow into v1.2 #31115

Merged
merged 3 commits into from May 23, 2022
Merged

Backport of build: Further polishing of the prototype build workflow into v1.2 #31115

merged 3 commits into from May 23, 2022

Commits on May 23, 2022

  1. build: Fetch all tags before deciding which version we're building 

    The actions/checkout workflow does some heroics to try to fetch exactly
the commit being built and nothing else, even if asked to fetch the
history leading up to that commit. That means we don't end up having
enough information to get an accurate answer from "git describe".

Since we're intentionally relying on the git history here, we'll fetch
all of the tags explicitly after initial checkout. Although that does add
some delay to this step, we're intentionally doing this version
calculation only once as a separate workflow job so that all of the other
jobs can still benefit from this action's quicker checkout behavior.
    @apparentlymart
    apparentlymart committed May 23, 2022
    Configuration menu
    Copy the full SHA
    bd0a550 View commit details
    Browse the repository at this point in the history

  2. build: Write the detected version number into the generated executable 

    This also sets an additional variable if it detects that this is an alpha
or development build, which currently does nothing but might eventually
turn on the ability to use experimental features, if we make that
something available only in prereleases.
    @apparentlymart
    apparentlymart committed May 23, 2022
    Configuration menu
    Copy the full SHA
    6c2d77b View commit details
    Browse the repository at this point in the history

  3. build: Accept version numbers with prereleases containing dashes 

    Previously we'd discard everything after the second dash.
    @apparentlymart
    apparentlymart committed May 23, 2022
    Configuration menu
    Copy the full SHA
    643c7dc View commit details
    Browse the repository at this point in the history