Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of copy dependency values when sorting into v1.2 #31249

Merged

Conversation

teamterraform
Copy link
Contributor

Backport

This PR is auto-generated from #31246 to be assessed for backporting due to the inclusion of the label 1.2-backport.

The below text is copied from the body of the original PR.


Expanded resource instances can initially share the same dependency
slice, so we must take care to not modify the array values when
checking the dependencies.

In the future we can convert these to a generic Set data type, as we
often need to compare for equality and take the union of multiple groups
of dependencies.

Fixes #31243

@teamterraform teamterraform force-pushed the backport/jbardin/copy-deps-for-comparison/daily-first-deer branch from 2bce467 to f68a499 Compare June 14, 2022 16:45
@jbardin jbardin merged commit c975f4e into v1.2 Jun 14, 2022
@jbardin jbardin deleted the backport/jbardin/copy-deps-for-comparison/daily-first-deer branch June 14, 2022 17:00
@github-actions
Copy link

Reminder for the merging maintainer: if this is a user-visible change, please update the changelog on the appropriate release branch.

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants