Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of http-backend: http backend lock error return LockError instead of generic error into v1.2 #31262

Merged
merged 1 commit into from Jun 17, 2022

Conversation

teamterraform
Copy link
Contributor

Backport

This PR is auto-generated from #31256 to be assessed for backporting due to the inclusion of the label 1.2-backport.

The below text is copied from the body of the original PR.


This PR make the http backend respect the lock-timeout flag. Currently, there is no way to wait for a lock when using http backend.
With this PR :

  1. Http backend now returns a LockError instead of a generic Error whenever the http post to lock the state returns HTTP code StatusConflict (409) or StatusLocked (423).
  2. Http backend will now respect correctly the lock-timeout flag.

@teamterraform teamterraform requested a review from a team as a code owner June 17, 2022 14:49
@teamterraform teamterraform force-pushed the backport/vanheu/http-patch/lovely-knowing-polliwog branch from fd04d73 to c939825 Compare June 17, 2022 14:49
@alisdair alisdair merged commit 1cc79ee into v1.2 Jun 17, 2022
@alisdair alisdair deleted the backport/vanheu/http-patch/lovely-knowing-polliwog branch June 17, 2022 14:55
@github-actions
Copy link

Reminder for the merging maintainer: if this is a user-visible change, please update the changelog on the appropriate release branch.

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants