Backport of states/remote: Check for LockError error type into v1.2 #31264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teamterraform
force-pushed
the
backport/alisdair/backend-remote-locks-helper-lockerror-test/miserably-growing-stag
branch
from
f6c2e72
to
516e4e9
Compare
alisdair
deleted the
backport/alisdair/backend-remote-locks-helper-lockerror-test/miserably-growing-stag
branch
|
Reminder for the merging maintainer: if this is a user-visible change, please update the changelog on the appropriate release branch. |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #31263 to be assessed for backporting due to the inclusion of the label 1.2-backport.
The below text is copied from the body of the original PR.
When attempting to lock a remote state backend, failure due to an existing lock should return an instance of
LockError. This allows the wrapping code to retry until the specified timeout, instead of immediately exiting.This commit adds a test for this in the
TestRemoteLockstest helper, which is used in many of the remote state backend test suites.This would have caught the bug fixed by #31256, for example, and the http backend tests fail without the commit in that PR.