core: Potential optimization of ModuleExpansionTransformer #31302
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This aims to amortize the cost of unique-keying and comparing module addresses by doing a single up-front transform of all of them into
UniqueKey
values. This was motivated by noticing some potential low-hanging fruit in the report over in #30968.Internally these
UniqueKey
values are really just string addresses and so comparing these boils down to just a string comparison in practice.I only wrote this up to see if it would be possible to do it, and so I've not actually measured if it's any faster this way. I'll need to develop a realistic benchmark to measure this with first before we can decide if this is a productive optimization. This didn't fit so neatly into my remaining work day as I'd hoped and so I've run out of time for now but might poke at this some more later.