Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests failing on main #31481

Merged
merged 1 commit into from Jul 20, 2022
Merged

Fix tests failing on main #31481

merged 1 commit into from Jul 20, 2022

Conversation

liamcervante
Copy link
Member

I merged the following three PRs without merging from main between merges:

One of them added a new event type, that then wasn't included in a test from an earlier one.

@liamcervante liamcervante requested review from kmoe and a team July 20, 2022 13:04
@liamcervante liamcervante added the v1.2 Issues (primarily bugs) reported against v1.2 releases label Jul 20, 2022
@liamcervante
Copy link
Member Author

I've added the v1.2 label, so the backporting bot will also fix the same broken test in the v1.2 branch.

@kmoe
Copy link
Member

kmoe commented Jul 20, 2022

I think you want the 1.2-backport label.

@liamcervante liamcervante added 1.2-backport If you add this label to a PR before merging, backport-assistant will open a new PR once merged and removed v1.2 Issues (primarily bugs) reported against v1.2 releases labels Jul 20, 2022
@liamcervante
Copy link
Member Author

I think you want the 1.2-backport label.

Yes!

@liamcervante liamcervante merged commit ad5ac89 into main Jul 20, 2022
@github-actions
Copy link

Reminder for the merging maintainer: if this is a user-visible change, please update the changelog on the appropriate release branch.

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
1.2-backport If you add this label to a PR before merging, backport-assistant will open a new PR once merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants