Commits on Sep 28, 2022

1. core: Don't re-register checkable outputs during the apply step …

   Once again we're caught out by sharing the same output value node type
   between the plan phase and the apply phase. To allow for some slight
   variation between plan and apply without drastic refactoring here we just
   add a new flag to nodeExpandOutput which is true only during the planning
   phase.
   
   This then allows us to register the checkable objects only during the
   planning phase and not incorrectly re-register them during the apply phase.
   It's incorrect to re-register during apply because we carry over the
   planned checkable objects from the plan phase into the apply phase so we
   can guarantee that the final state will have all of the same checkable
   objects that the plan did.
   
   This avoids a panic during the apply phase from the incorrect duplicate
   registration.

   

   apparentlymart committed Sep 28, 2022
   Copy the full SHA

   e28b1c8 View commit details

   Browse the repository at this point in the history