Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract more exact provider name when checking for destroy cycles #31917

Merged
merged 2 commits into from Oct 4, 2022
Merged

Extract more exact provider name when checking for destroy cycles #31917

merged 2 commits into from Oct 4, 2022

Commits on Oct 4, 2022

  1. check detailed provider for destroy edge cycles 

    When we checked for cycles with destroy edges around providers, it was
only for providers of a different type, but one can do the same thing
with the same provider under different local aliases. Check to see if
the provider also contains an alias, or is defined absolutely in some
other way. The absolute accuracy here isn't critical, since in most
cases these edges are not required for correct results, but finding a
correct and consistent method for determining when these edges are
needed is going to take more research.

There was also an oversight fixed here where the basic
creator->destroyer edges were added _after_ the cycle checks, limiting
their utility. The ordering of the additions was swapped to make sure
all cycles are noticed.
    @jbardin
    jbardin committed Oct 4, 2022
    Copy the full SHA
    036fb9c View commit details
    Browse the repository at this point in the history

  2. test for cycle around aliased provider

    @jbardin
    jbardin committed Oct 4, 2022
    Copy the full SHA
    c296172 View commit details
    Browse the repository at this point in the history