Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up handling of check-related graph nodes #32051

Merged
merged 16 commits into from Oct 20, 2022

Commits on Oct 19, 2022

  1. fix error message

    jbardin committed Oct 19, 2022
    Copy the full SHA
    5085ccd View commit details
    Browse the repository at this point in the history
  2. walkDestroy op in apply graph

    jbardin committed Oct 19, 2022
    Copy the full SHA
    71837d1 View commit details
    Browse the repository at this point in the history
  3. outputs should not be checked during destroy

    Module output may need to be evaluated during destroy in order to
    possibly be used by providers. The final state however is that all
    objects are destroyed, so preconditions should not be evaluated.
    jbardin committed Oct 19, 2022
    Copy the full SHA
    8a24d73 View commit details
    Browse the repository at this point in the history
  4. complete the root output expansion

    Not all root output instances were going through proper expansion when
    destroy operations were involved, leading to cases where they would be
    evaluated even though the expected result was only to remove them from
    the state.
    
    Normally destroy nodes stand alone in the graph, and do not produce
    references to other nodes. Because root output nodes were replaced by
    expansion nodes, these were being connected via normal references, even
    in the case where we were working with a destroy graph.
    jbardin committed Oct 19, 2022
    Copy the full SHA
    bcb792e View commit details
    Browse the repository at this point in the history
  5. remove IsFullDestroy workaround

    IsFullDestroy was a workaround during apply to detect when the change
    set was created by a destroy plan. This no longer works correctly, and
    we need to fall back to the UIMode set in the plan.
    jbardin committed Oct 19, 2022
    Copy the full SHA
    47b6386 View commit details
    Browse the repository at this point in the history
  6. fix output transformer names

    The removeRootOutputs field was not strictly used for that purpose, and
    was also copied to another DestroyPlan field.
    jbardin committed Oct 19, 2022
    Copy the full SHA
    1eb22fd View commit details
    Browse the repository at this point in the history
  7. Copy the full SHA
    333bdec View commit details
    Browse the repository at this point in the history
  8. Copy the full SHA
    a072344 View commit details
    Browse the repository at this point in the history
  9. Copy the full SHA
    0808109 View commit details
    Browse the repository at this point in the history
  10. the destroy refresh plan should be refresh-only

    Refreshing for a destroy should use the refresh-only plan to avoid
    planning new objects or evaluating conditions. This should also be
    skipped if there is no state, since there would be nothing to refresh.
    jbardin committed Oct 19, 2022
    Copy the full SHA
    8d11c7f View commit details
    Browse the repository at this point in the history
  11. don't eval checks on destroy

    jbardin committed Oct 19, 2022
    Copy the full SHA
    8a4883f View commit details
    Browse the repository at this point in the history

Commits on Oct 20, 2022

  1. make naming consistent

    jbardin committed Oct 20, 2022
    Copy the full SHA
    586401a View commit details
    Browse the repository at this point in the history
  2. NoOp nodes should not have destroy edges

    NoOp changes should not participate in a destroy sequence, but because
    they are included as normal update nodes the usual connections were
    still being made.
    jbardin committed Oct 20, 2022
    Copy the full SHA
    28d5a5b View commit details
    Browse the repository at this point in the history
  3. remove extra import line

    jbardin committed Oct 20, 2022
    Copy the full SHA
    ac99cd6 View commit details
    Browse the repository at this point in the history
  4. update UIMode comment

    jbardin committed Oct 20, 2022
    Copy the full SHA
    a44c859 View commit details
    Browse the repository at this point in the history
  5. fix variable name

    jbardin committed Oct 20, 2022
    Copy the full SHA
    92c8c76 View commit details
    Browse the repository at this point in the history