Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ensure destroy edges from data sources #32209

Merged
merged 1 commit into from
Dec 1, 2022

Conversation

jbardin
Copy link
Member

@jbardin jbardin commented Nov 11, 2022

Data resource dependencies are not stored in the state, so we need to take the latest dependency set to use for any direct connections to destroy nodes.

Fixes #32179

Data resource dependencies are not stored in the state, so we need to
take the latest dependency set to use for any direct connections to
destroy nodes.
Copy link
Member

@kmoe kmoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jbardin jbardin merged commit cbcae84 into main Dec 1, 2022
@jbardin jbardin deleted the jbardin/data-source-destroy-edges branch December 1, 2022 15:25
@github-actions
Copy link

github-actions bot commented Dec 1, 2022

Reminder for the merging maintainer: if this is a user-visible change, please update the changelog on the appropriate release branch.

@github-actions
Copy link

github-actions bot commented Jan 1, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Data source dependent on for_each/count resource doesn't wait for destroy before reading.
2 participants