New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use the apparentlymart/go-versions library to parse module constraints #32377
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
5b27ff2
Use the apparentlymart/go-versions library to parse module constraints
liamcervante 1f12d16
goimports
liamcervante e82ef31
Update comments, and parse versions carefully
liamcervante 57ef86b
add acceptance tests to verify behaviour of partial matches
liamcervante a1d4541
goimports
liamcervante File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 changes: 7 additions & 0 deletions
7
internal/initwd/testdata/prerelease-version-constraint-match/root.tf
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
# We expect this test to download the requested version because it is an exact | ||
# match for a prerelease version. | ||
|
||
module "acctest_exact" { | ||
source = "hashicorp/module-installer-acctest/aws" | ||
version = "=0.0.3-alpha.1" | ||
} |
8 changes: 8 additions & 0 deletions
8
internal/initwd/testdata/prerelease-version-constraint/root.tf
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
# We expect this test to download the version 0.0.2, the one before the | ||
# specified version even with the equality because the specified version is a | ||
# prerelease. | ||
|
||
module "acctest_partial" { | ||
source = "hashicorp/module-installer-acctest/aws" | ||
version = "<=0.0.3-alpha.1" | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's interesting to note that this effectively means that any prerelease versions announced by the registry will be subject to
apparentlymart/go-versions
matching before we get to thereq.VersionConstraints.Check(v)
call below.I don't think this is actually a problem -- this is still more general than the direct string comparison it is replacing -- but might be worth a comment noting this in the hope of minimizing confusion for a future maintainer here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added additional comments, expanding on the context. Hopefully it's more clear now 😅