Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure we have all references for output preconditions #32464

Merged
merged 2 commits into from Jan 5, 2023
Merged

Ensure we have all references for output preconditions #32464

merged 2 commits into from Jan 5, 2023

Commits on Jan 5, 2023

  1. output refs missing error_message 

    Output references must also include the error_message expression.
Fix the early return in referencesForOutput, which could skip
preconditions. The small slice allocation optimization is not really
needed here, since this is not a hot path at all.
    @jbardin
    jbardin committed Jan 5, 2023
    Copy the full SHA
    1790f84 View commit details
    Browse the repository at this point in the history

  2. test references only from output preconditions 

    These references were getting dropped, which could cause the referenced
nodes to be pruned from the graph.
    @jbardin
    jbardin committed Jan 5, 2023
    Copy the full SHA
    45cb048 View commit details
    Browse the repository at this point in the history