Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix(cliconfig.go): emit a warning msg if invalid CLI configuration file location #32793

Conversation

rkhaled0
Copy link
Contributor

@rkhaled0 rkhaled0 commented Mar 7, 2023

This Pull Request is about noticing people when TF_CLI_CONFIG_FILE environment variable points to a non existing file.

In such case, a warning message will be printed out like below;

There are some problems with the CLI configuration:
╷
│ Warning: Unable to open CLI configuration file
│
│ The CLI configuration file at
│ "/private/var/folders/7b/q4m7dd2x4fl8ltp731djsw940000gn/T/tmp.5TVZNsJu/.terraform.rcr"
│ specified does not exist.
╵

Fixes #32646

Target Release

1.4.x

Draft CHANGELOG entry

BUG FIXES

  • When setting an invalid CLI configuration file location, emit a warning message

@rkhaled0 rkhaled0 marked this pull request as ready for review March 7, 2023 17:29
@crw
Copy link
Collaborator

crw commented Mar 7, 2023

Thanks for this submission!

@crw crw added the bug label Mar 7, 2023
@jbardin jbardin added the 1.4-backport If you add this label to a PR before merging, backport-assistant will open a new PR once merged label Mar 14, 2023
@jbardin
Copy link
Member

jbardin commented Mar 14, 2023

Thanks @rkhaled0, rebased and merged in #32846

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
1.4-backport If you add this label to a PR before merging, backport-assistant will open a new PR once merged bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve user feedback about 'bad' values of TF_CLI_CONFIG_FILE environment variable
3 participants