Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

External changes report can fail with schema migrations and -target #32900

Merged
merged 2 commits into from
Mar 28, 2023
Merged

External changes report can fail with schema migrations and -target #32900

merged 2 commits into from
Mar 28, 2023

Commits on Mar 21, 2023

  1. prevent errors with -target and provider upgrades 

    In the case where a provider has been upgraded, and there are external
changes to resources outside of terraform, and -target is being used,
and resources which are not targeted require a schema migration; the
untargeted resources will not have been migrated and cannot be decoded for the
external changes report.

Since there is no way to decode the resources which have been excluded
via -target, we can only skip over them when inspecting
driftedResources. Return warnings for now to indicate that these
resources could not be decoded to help indicate that users will need to
eventually apply these changes.
    @jbardin
    jbardin committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    b10c4c5 View commit details
    Browse the repository at this point in the history

  2. test for untargeted schema mismatch

    @jbardin
    jbardin committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    240e345 View commit details
    Browse the repository at this point in the history