Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of External changes report can fail with schema migrations and -target into v1.4 #32932

Merged

Conversation

teamterraform
Copy link
Contributor

Backport

This PR is auto-generated from #32900 to be assessed for backporting due to the inclusion of the label 1.4-backport.

The below text is copied from the body of the original PR.


When creating a plan under the following conditions:

  • A provider has been upgraded with changes to the schema
  • There are external changes to resources outside of terraform
  • The -target flag is being used
  • Resources which are not targeted require a schema migration

The un-targeted resources will not have been migrated to a new schema and cannot be decoded from the prior state for the external changes report.

Since there is no way to decode these resources which have been excluded via -target, we can only skip over them when inspecting driftedResources. Return warnings for now to indicate that these resources could not be decoded and users will need to eventually apply these changes.

Fixes #31052

@teamterraform teamterraform force-pushed the backport/jbardin/target-drift-upgrade/widely-tidy-weasel branch 2 times, most recently from e9c774f to 077fec3 Compare March 28, 2023 19:51
@teamterraform teamterraform force-pushed the backport/jbardin/target-drift-upgrade/widely-tidy-weasel branch from bec3319 to 3bde1c1 Compare March 28, 2023 19:51
@jbardin jbardin merged commit 446bc09 into v1.4 Mar 28, 2023
@jbardin jbardin deleted the backport/jbardin/target-drift-upgrade/widely-tidy-weasel branch March 28, 2023 20:01
@github-actions
Copy link

Reminder for the merging maintainer: if this is a user-visible change, please update the changelog on the appropriate release branch.

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants