Skip to content

Add native plantimestamp function to Terraform #32980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 21, 2023

Conversation

liamcervante
Copy link
Member

@liamcervante liamcervante commented Apr 4, 2023

New function will return a constant time representing the UTC timestamp during the plan.

Proposed changelog entry

NEW FEATURES

  • Adds a new plantimestamp function that returns the timestamp at plan time. This is similar to the timestamp function which returns the timestamp at apply time.

@liamcervante liamcervante force-pushed the liamcervante/plan-timestamp branch from 02adb92 to 0f1507b Compare April 5, 2023 14:03
@liamcervante liamcervante requested a review from a team April 6, 2023 11:24
@liamcervante liamcervante marked this pull request as ready for review April 6, 2023 11:24
@liamcervante liamcervante changed the title [WIP]: Add native plantimestamp function to Terraform Add native plantimestamp function to Terraform Apr 6, 2023
@liamcervante liamcervante marked this pull request as draft April 6, 2023 12:59
@liamcervante liamcervante removed the request for review from a team April 6, 2023 13:00
@liamcervante liamcervante marked this pull request as ready for review April 6, 2023 15:33
Copy link
Contributor

@alisdair alisdair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I don't understand the docs linter/build error, though. I imagine we'll have to figure that out before merge.

Verified

This commit was signed with the committer’s verified signature.
bflad Brian Flad

Verified

This commit was signed with the committer’s verified signature.
bflad Brian Flad
@liamcervante liamcervante merged commit aae6990 into main Apr 21, 2023
@liamcervante liamcervante deleted the liamcervante/plan-timestamp branch April 21, 2023 07:47
@github-actions
Copy link
Contributor

Reminder for the merging maintainer: if this is a user-visible change, please update the changelog on the appropriate release branch.

@github-actions
Copy link
Contributor

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants