Skip to content

backend/s3: Adds parameter skip_s3_checksum to skip checksum on upload #34127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 24, 2023

Conversation

gdavison
Copy link
Contributor

@gdavison gdavison commented Oct 23, 2023

Some "S3-compatible" APIs do not support the header x-amz-sdk-checksum-algorithm. In the S3 API, a checksum is recommended and is required when Object Lock is enabled.

Allow users to disable the header.

Fixes #34099
Fixes #34086
Relates #34053 (comment)

Target Release

1.6.3

Draft CHANGELOG entry

ENHANCEMENTS

  • backend/s3: Allows users to disable checksum on S3 uploads for compatibility with "S3-compatible" APIs

@gdavison gdavison requested a review from a team as a code owner October 23, 2023 23:19
@gdavison gdavison added the 1.6-backport If you add this label to a PR before merging, backport-assistant will open a new PR once merged label Oct 23, 2023
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

% TF_ACC=1 go test -count=1 ./internal/backend/remote-state/s3/...
ok      github.com/hashicorp/terraform/internal/backend/remote-state/s3 144.245s

@gdavison gdavison merged commit 57e2fc9 into main Oct 24, 2023
@gdavison gdavison deleted the s3/b-s3-checksum branch October 24, 2023 18:32
@github-actions
Copy link
Contributor

Reminder for the merging maintainer: if this is a user-visible change, please update the changelog on the appropriate release branch.

@kamenskiyyyy
Copy link

@gdavison Hi! When will terraform 1.6.3 release be published?

@crw
Copy link
Contributor

crw commented Oct 27, 2023

@kamenskiyyyy It is variable, but in the normal state of events it would be available in the middle of next week. This can change depending on variety of factors.

Copy link
Contributor

github-actions bot commented Dec 7, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
1.6-backport If you add this label to a PR before merging, backport-assistant will open a new PR once merged backend/s3 enhancement
Projects
None yet
4 participants