New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backport of docs: Terraform style guide into v1.5 #34909
Open
teamterraform
wants to merge
19
commits into
v1.5
Choose a base branch
from
backport/WAF-110-Terraform-Code-Style-Guide/correctly-smart-hermit
base: v1.5
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Backport of docs: Terraform style guide into v1.5 #34909
teamterraform
wants to merge
19
commits into
v1.5
from
backport/WAF-110-Terraform-Code-Style-Guide/correctly-smart-hermit
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teamterraform
force-pushed
the
backport/WAF-110-Terraform-Code-Style-Guide/correctly-smart-hermit
branch
from
March 28, 2024 22:15
1d83756
to
104fb9c
Compare
BrianMMcClain
approved these changes
Mar 28, 2024
ritsok
approved these changes
Apr 1, 2024
radeksimko
reviewed
Apr 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nitpick: Would you mind cherry-picking this small fix #34938 here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #34876 to be assessed for backporting due to the inclusion of the label 1.5-backport.
The below text is copied from the body of the original PR.
Note: This PR requires a redirect from the existing style conventions doc. Once this PR is merged, merge hashicorp/terraform-docs-common#584
馃攳 Deploy preview
The Well-Architected Framework team has gathered feedback from HashiCorp employees and Terraform users in an attempt to build on our recommended style contentions. The intention of this guide is that it is used by those looking to form their own internal standardized style guide.
This guide is split into two parts:
This guide is a mix of prescriptive advice and non-prescriptive considerations, as some scenarios truly depend on the situation.
Overview of commits