backend/pg: Stop using legacy helper/schema #34987
Open
+74
−84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The legacy SDK is a very heavy dependency that this backend was only using tiny parts of. We'll now instead use our new "backendbase" package, which aims to provide a smaller set of helper functions that cover the main use-cases that the existing backends were relying on the SDK to meet, but with considerably less code and fewer layers of abstraction.
There were two failing ACC tests with this update. One from from a newer version of pg, which causes a different auth error message. The other is is directly related to this PR, which was checking for a specific schema error, which is now `invalid value for "skip_schema_creation"` when a non-bool argument is present.
|
Since we don't have an active in-house maintainer for this backend, in order to expedite review and prevent this from becoming stale, I updated the PR to pass all acceptance tests with a current postgresql version. There were only 2 minor test scenario changes, both unrelated to functionality. The auth error checked by one test changed in the past few years, and the schema error checked by another test changed with the removal of the legacy SDK. |
|
@remilapeyre Just an FYI, I do not think an action is needed at this time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The legacy SDK is a very heavy dependency that this backend was only using tiny parts of.
We'll now instead use our new "backendbase" package, which aims to provide a smaller set of helper functions that cover the main use-cases that the existing backends were relying on the SDK to meet, but with considerably less code and fewer layers of abstraction.
In the long run we're still planning to move all of the state storage backends out to provider plugins, but the legacy SDK is quite a liability because few people know how to maintain it while hopefully this interim
backendbasepackage is easier to maintain (if needed) due to its relative simplicity.I don't have any test environment for this backend, so I've only tested this through its unit tests. I'd appreciate if a backend maintainer could, along with reviewing this code, also run the acceptance test suite in case there are regressions that the unit tests aren't able to catch. Thanks!