New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add acceptance and internal tests for gcs
backend, add some test helper functions
#35026
Open
SarahFrench
wants to merge
10
commits into
main
Choose a base branch
from
add-gcs-test
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+414
−106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SarahFrench
force-pushed
the
add-gcs-test
branch
from
April 18, 2024 22:39
01757ad
to
c0622f8
Compare
SarahFrench
force-pushed
the
add-gcs-test
branch
from
April 25, 2024 13:28
c0622f8
to
ed83722
Compare
…doesn't affect use of ENV-supplied credentials
…rp/terraform PRs
… let checks pass in hashicorp/terraform repo.
SarahFrench
force-pushed
the
add-gcs-test
branch
from
April 25, 2024 20:44
f93c4f7
to
b5abe9f
Compare
Just rebased to include the latest gcs PR |
Move `TestBackendEncryptionKeyEmptyConflict` test to internal test file
SarahFrench
force-pushed
the
add-gcs-test
branch
from
April 25, 2024 20:48
5801a6d
to
e31ddb3
Compare
SarahFrench
changed the title
Add tests for gcs backend
Add acceptance and internal tests for Apr 26, 2024
gcs
backend, add some test helper functions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Historically the
gcs
backend hasn't been touched much. In the past I've added a few features but largely left the existing codebase as it was previously. Recently thegcs
backend was refactored in #34989 to avoid using the old SDK.As part of reviewing that PR I started adding a few acceptance tests in this PR. There's a lot more work to be done but I want to avoid this PR getting too big.
This PR:
gcs
backend set up (//TODO!)TestBackendConfig_encryptionKey
- how the config and ENVs for customer-supplied encryption keys are usedTestBackendConfig_kmsKey
- how the config and ENVs for customer-managed (KMS) encryption keys are usedTestAccBackendConfig_credentials
- empty strings in the backend config don't interrupt use of ENVs for creds.Target Release
1.8.x
Draft CHANGELOG entry
NEW FEATURES | UPGRADE NOTES | ENHANCEMENTS | BUG FIXES | EXPERIMENTS