Allow for system & user-assigned identity auth & misc #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update to go1.17.6 - Rev dependencies - Use 2021-11-01 compute client sdk - Remove unused params & address other codestyle issues Fix #35
|
@calvn Tagging you since you reviewed my past PRs, thanks! |
jasonodonnell
approved these changes
Feb 14, 2022
|
We're double checking some dependency updates with the Vault project, then will merge if things look good! |
jasonodonnell
pushed a commit
that referenced
this pull request
Feb 17, 2022
- Update to go1.17.6 - Rev dependencies - Use 2021-11-01 compute client sdk - Remove unused params & address other codestyle issues Fix #35
jasonodonnell
added a commit
that referenced
this pull request
Feb 17, 2022
* Allow for system & user-assigned identity auth & misc (#50) - Update to go1.17.6 - Rev dependencies - Use 2021-11-01 compute client sdk - Remove unused params & address other codestyle issues Fix #35 * Use object ID for the logical name (#34) Co-authored-by: Jonas-Taha El Sesiy <github@elsesiy.com> Co-authored-by: cccs-ob <60484080+cccs-ob@users.noreply.github.com>
This was referenced Feb 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Related Issues/Pull Requests
Fix #35
Contributor Checklist
[ ] Add relevant docs to upstream Vault repository, or sufficient reasoning why docs won’t be added yet
My Docs PR Link
Example
[ ] Add output for any tests not ran in CI to the PR description (eg, acceptance tests)
[x] Backwards compatible