Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for using MS Graph instead of AAD #67

Merged
merged 8 commits into from Sep 24, 2021
Merged

Add support for using MS Graph instead of AAD #67

merged 8 commits into from Sep 24, 2021

Commits on Aug 30, 2021

  1. Use the MS Graph API for atomic add/remove password operations

    Azure Active Directory Graph API, now deprecated, does not provide
    support for atomically creating/removing passwords on an application. As
    a result, there is a race conditions that can occur when creds are being
    created for roles configured with an existing service principal that
    is configured on multiple mounts or across multiple Vault clusters.
    
    Unfortunately,
    [`Azure/azure-sdk-for-go`](https://github.com/Azure/azure-sdk-for-go)
    does not yet offer a MS Graph API client, therefore, this PR utilizes
    [`Azure/go-autorest`](https://github.com/Azure/go-autorest) to construct
    a client the same as
    [`Azure/azure-sdk-for-go`](https://github.com/Azure/azure-sdk-for-go).
    
    This changeset preserves using the AAD Graph API by default but provides
    a mount configuration option for toggling to the new MS Graph API. This
    is because the two APIs require different API permissions. This allows
    users to upgrade to the new plugin version and then switch to the new
    API.
    
    Additionally, although using the MS Graph API is a net benefit, it
    itself has reliability issues when handling multiple requests in
    parallel. More details can be found in
    https://github.com/mdgreenfield/microsoft-graph-api-reliability and I am
    working with Microsoft to try to get some of these reliability issues
    resolved.
    
    Fixes #58
    mdgreenfield committed Aug 30, 2021
    Configuration menu
    Copy the full SHA
    b5fa247 View commit details
    Browse the repository at this point in the history

Commits on Sep 3, 2021

  1. Configuration menu
    Copy the full SHA
    adc4910 View commit details
    Browse the repository at this point in the history

Commits on Sep 15, 2021

  1. Configuration menu
    Copy the full SHA
    58d747b View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    fec9a43 View commit details
    Browse the repository at this point in the history
  3. Adjust tests for retry logic

    pcman312 committed Sep 15, 2021
    Configuration menu
    Copy the full SHA
    0c52a46 View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2021

  1. ADGroup -> Group

    pcman312 committed Sep 20, 2021
    Configuration menu
    Copy the full SHA
    b2a290a View commit details
    Browse the repository at this point in the history

Commits on Sep 22, 2021

  1. Configuration menu
    Copy the full SHA
    2b07268 View commit details
    Browse the repository at this point in the history

Commits on Sep 23, 2021

  1. Configuration menu
    Copy the full SHA
    3f4f563 View commit details
    Browse the repository at this point in the history