New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update authorization to 2018-01-01 preview #83
Conversation
@@ -4,7 +4,7 @@ import ( | |||
"context" | |||
"time" | |||
|
|||
"github.com/Azure/azure-sdk-for-go/profiles/latest/authorization/mgmt/authorization" | |||
"github.com/Azure/azure-sdk-for-go/services/preview/authorization/mgmt/2018-01-01-preview/authorization" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see that there are other versions under authorization/mgmt, is there a reason we're going with this one in particular?
There is also a non-preview version for 2018-03-01 and other newer ones.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From the diff it appears we originally used 2018-01-01-preview
prior to merging #67. That PR switched to using profiles/latest
, which appears to point to 2015-07-01. I think that explains why this error is showing up now.
Using 2018-01-01-preview
should be fine, but we might want to use something more recent as @calvn suggested. It looks like terraform-provider-azurerm is using 2020-04-01-preview.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch @austingebauer. Let's take a stepwise approach and upgrade back to what it was before, and we can look into bumping that up further afterwards (along with more testing). So upgrading to 2018-01-01-preview sounds good to me.
I was able to reproduce the error in #82 and verify that this PR fixes it for both AAD graph and MS graph configurations. Additionally, I fixed the acceptance tests and added coverage for using the Acceptance test output:
|
* Update authorization to 2018-01-01 preview * Fixes AAD tests; Adds coverage for Storage Blob Data Owner in MS graph tests Co-authored-by: Austin Gebauer <agebauer@hashicorp.com>
* Update authorization to 2018-01-01 preview * Fixes AAD tests; Adds coverage for Storage Blob Data Owner in MS graph tests Co-authored-by: Austin Gebauer <agebauer@hashicorp.com> Co-authored-by: Jason O'Donnell <2160810+jasonodonnell@users.noreply.github.com>
I'm updating the authorization packages to 2018-01-01 preview to support roles that use data actions in Azure. The existing authorization package points to 2015-07-01, which does not support them.
Fixes #82.