Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enable hierarchical path for dynamic roles and creds #104

Merged
merged 13 commits into from
May 10, 2024
Merged

enable hierarchical path for dynamic roles and creds #104

merged 13 commits into from
May 10, 2024

Conversation

fairclothjm
Copy link
Contributor

Phase 2 of #102 and is based on that branch.

This PR adds hierarchical path handling to the following APIs:

@fairclothjm fairclothjm requested a review from a team May 8, 2024 19:49
@fairclothjm fairclothjm mentioned this pull request May 8, 2024
Closed
vinay-gopalan
vinay-gopalan approved these changes May 9, 2024
View reviewed changes
Copy link

@vinay-gopalan vinay-gopalan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! PR is in line with the updates made to static roles and creds. I'm fine with any remaining test improvements and TODOs being addressed in follow up PRs

@fairclothjm
Copy link
Contributor Author

Thanks!

@fairclothjm fairclothjm merged commit 9d63d94 into main May 10, 2024
5 checks passed
@fairclothjm fairclothjm deleted the dynamic-creds/VAULT-26642/hierarchical-paths branch May 10, 2024 19:38
@fairclothjm fairclothjm mentioned this pull request May 14, 2024
Merged
@fairclothjm fairclothjm mentioned this pull request May 23, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vinay-gopalan vinay-gopalan vinay-gopalan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fairclothjm @vinay-gopalan @austingebauer