Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix early rotation for roles with WALs, handle multiple WALs per role #28

Merged
merged 23 commits into from Sep 21, 2021
Merged

Fix early rotation for roles with WALs, handle multiple WALs per role #28

merged 23 commits into from Sep 21, 2021

Commits on Sep 14, 2021

  1. Guard against premature rotation

    @tomhjp
    Jim Kalafut authored and tomhjp committed Sep 14, 2021
    Configuration menu
    Copy the full SHA
    dac711c View commit details
    Browse the repository at this point in the history

  2. Add more logging

    @tomhjp
    Jim Kalafut authored and tomhjp committed Sep 14, 2021
    Configuration menu
    Copy the full SHA
    ea46314 View commit details
    Browse the repository at this point in the history

  3. Fix logged version number

    @tomhjp
    Jim Kalafut authored and tomhjp committed Sep 14, 2021
    Configuration menu
    Copy the full SHA
    59eafe9 View commit details
    Browse the repository at this point in the history

  4. Stop current rotation loop if we hit a premature rotation condition

    @tomhjp
    Jim Kalafut authored and tomhjp committed Sep 14, 2021
    Configuration menu
    Copy the full SHA
    fb8d6db View commit details
    Browse the repository at this point in the history

  5. Add more WAL logging

    @tomhjp
    Jim Kalafut authored and tomhjp committed Sep 14, 2021
    Configuration menu
    Copy the full SHA
    61fa8a7 View commit details
    Browse the repository at this point in the history

  6. More WAL logging

    @tomhjp
    Jim Kalafut authored and tomhjp committed Sep 14, 2021
    Configuration menu
    Copy the full SHA
    2cf0db2 View commit details
    Browse the repository at this point in the history

  7. gofmt rotation.go

    @calvn @tomhjp
    calvn authored and tomhjp committed Sep 14, 2021
    Configuration menu
    Copy the full SHA
    64e5a98 View commit details
    Browse the repository at this point in the history

  8. Fix early rotation for roles with WALs, handle multiple WALs per role

    @tomhjp
    tomhjp committed Sep 14, 2021
    Configuration menu
    Copy the full SHA
    5ec68fb View commit details
    Browse the repository at this point in the history

  9. Review changes: 

    * Respect previous WAL's new password
* Ensure only 1 WAL per role
* Reinstate finding a WAL => rotate immediately
* Remove patch check that would stop manual rotations when popping from the queue
* Add a warning to manual rotation response when rotation not immediately successful
* Remove re-storing of mount config when rotating unrelated roles
* Discard all WALs with a previous rotation time of 0
* Remove deleted WAL IDs from queue items
* Delete unused struct fields
    @tomhjp
    tomhjp committed Sep 14, 2021
    Configuration menu
    Copy the full SHA
    e3eb497 View commit details
    Browse the repository at this point in the history

  10. Switch from warning to error to correct HTTP status code from 400 -> 500

    @tomhjp
    tomhjp committed Sep 14, 2021
    Configuration menu
    Copy the full SHA
    30ce185 View commit details
    Browse the repository at this point in the history

Commits on Sep 15, 2021

  1. * Delete WALs on failed role creation or role deletion 

    * Take exclusive lock before reading config
* Validate input before creating output struct
* Comment updates
    @tomhjp
    tomhjp committed Sep 15, 2021
    Configuration menu
    Copy the full SHA
    2eff49f View commit details
    Browse the repository at this point in the history

  2. Fix a bug in role deletion WAL cleanup, add some WAL tests

    @tomhjp
    tomhjp committed Sep 15, 2021
    Configuration menu
    Copy the full SHA
    f89ce21 View commit details
    Browse the repository at this point in the history

  3. Delete test debug lines

    @tomhjp
    tomhjp committed Sep 15, 2021
    Configuration menu
    Copy the full SHA
    3cedec4 View commit details
    Browse the repository at this point in the history

  4. Fix manual rotate not respecting WAL ID, more unit testing

    @tomhjp
    tomhjp committed Sep 15, 2021
    Configuration menu
    Copy the full SHA
    7c7d98d View commit details
    Browse the repository at this point in the history

Commits on Sep 16, 2021

  1. Add tests for processing of stored WALs, remove bad assertion

    @tomhjp
    tomhjp committed Sep 16, 2021
    Configuration menu
    Copy the full SHA
    ad73e4d View commit details
    Browse the repository at this point in the history

  2. Remove old password from WAL

    @tomhjp
    tomhjp committed Sep 16, 2021
    Configuration menu
    Copy the full SHA
    76f9f03 View commit details
    Browse the repository at this point in the history

  3. Remove unnecessary multierror

    @tomhjp
    tomhjp committed Sep 16, 2021
    Configuration menu
    Copy the full SHA
    8dcd840 View commit details
    Browse the repository at this point in the history

  4. Distinguish between log lines

    @tomhjp
    tomhjp committed Sep 16, 2021
    Configuration menu
    Copy the full SHA
    4eac5a1 View commit details
    Browse the repository at this point in the history

  5. Add missing debug logs for cleaning up WALs, tidy build.sh

    @tomhjp
    tomhjp committed Sep 16, 2021
    Configuration menu
    Copy the full SHA
    cfbda98 View commit details
    Browse the repository at this point in the history

  6. Add error to debug messages

    @tomhjp
    tomhjp committed Sep 16, 2021
    Configuration menu
    Copy the full SHA
    fa193fa View commit details
    Browse the repository at this point in the history

Commits on Sep 17, 2021

  1. Add last check on newPassword

    @tomhjp
    tomhjp committed Sep 17, 2021
    Configuration menu
    Copy the full SHA
    78553e3 View commit details
    Browse the repository at this point in the history

Commits on Sep 21, 2021

  1. Minor test improvements ported from DB PR

    @tomhjp
    tomhjp committed Sep 21, 2021
    Configuration menu
    Copy the full SHA
    70e4c7b View commit details
    Browse the repository at this point in the history

  2. Log line ordering

    @tomhjp
    tomhjp committed Sep 21, 2021
    Configuration menu
    Copy the full SHA
    b32b685 View commit details
    Browse the repository at this point in the history