Skip to content

Commit

Permalink
fix and test fix (#13050)
Browse files Browse the repository at this point in the history
  • Loading branch information
Monkeychip committed Nov 4, 2021
1 parent 7f5d820 commit 063d19a
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
2 changes: 1 addition & 1 deletion ui/app/templates/components/secret-delete-menu.hbs
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
<button
type="button"
class="toolbar-link"
{{on "click" (fn (mut this.showDeleteModal) false)}}
{{on "click" (fn (mut this.showDeleteModal) true)}}
data-test-delete-open-modal
>
{{if (and (not @modelForData.deleted) (not @modelForData.destroyed)) "Delete" "Destroy"}}
Expand Down
1 change: 1 addition & 0 deletions ui/tests/acceptance/secrets/backend/kv/secret-test.js
Original file line number Diff line number Diff line change
Expand Up @@ -641,6 +641,7 @@ module('Acceptance | secrets/secret/create', function(hooks) {
await settled();
await click('[data-test-delete-open-modal]');
await settled();
assert.dom('.modal.is-active').exists('Modal appears');
assert.dom('[data-test-delete-modal="destroy-all-versions"]').exists(); // we have a if Ember.testing catch in the delete action because it breaks things in testing
// we can however destroy the versions
await click('#destroy-all-versions');
Expand Down

0 comments on commit 063d19a

Please sign in to comment.