Adds missing unlock of RWMutex in OIDC delete key (#12916)

hashicorp · Oct 25, 2021 · d0c0571 · d0c0571
1 parent dd80dbf
commit d0c0571
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 0 deletions.
diff --git a/changelog/12916.txt b/changelog/12916.txt
@@ -0,0 +1,3 @@
+```release-note:bug
+identity/token: Adds missing call to unlock mutex in key deletion error handling
+```
diff --git a/vault/identity_store_oidc.go b/vault/identity_store_oidc.go
@@ -634,6 +634,7 @@ func (i *IdentityStore) pathOIDCDeleteKey(ctx context.Context, req *logical.Requ
 
 	roleNames, err := i.roleNamesReferencingTargetKeyName(ctx, req, targetKeyName)
 	if err != nil {
+		i.oidcLock.Unlock()
 		return nil, err
 	}