Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix MSSQL compatibility with Azure SQL #11555

Closed
wants to merge 4 commits into from
Closed

Fix MSSQL compatibility with Azure SQL #11555

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d9289bc
Fix MSSQL UpdateUser compat with Azure SQL
g-psantos May 7, 2021
12ccd38
Add changelog entry for PR 11555
g-psantos May 7, 2021
dd1b0ad
Merge branch 'master' into mssql-fix-azuresql-change-pass
g-psantos May 11, 2021
f252207
Merge branch 'hashicorp:main' into mssql-fix-azuresql-change-pass
g-psantos Sep 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 3 additions & 0 deletions changelog/11555.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
```release-note:improvement
secrets/database/mssql: Enable password rotation for contained users
```
8 changes: 0 additions & 8 deletions plugins/database/mssql/mssql.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -329,14 +329,6 @@ func (m *MSSQL) updateUserPass(ctx context.Context, username string, changePass
return err
}

var exists bool

err = db.QueryRowContext(ctx, "SELECT 1 FROM master.sys.server_principals where name = N'$1'", username).Scan(&exists)

if err != nil && err != sql.ErrNoRows {
return err
}

tx, err := db.BeginTx(ctx, nil)
if err != nil {
return err
Expand Down