VAULT-2285 adding capability to accept comma separated entries for au… #12126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hghaf099
force-pushed
the
hghaf099-VAULT-2285-fix-headers-accept-comma-sep-ent
branch
from
3e6c136
to
e8515b3
Compare
|
Seems like secrets tune/enable are also missing the same parameters. |
ncabatoff
reviewed
Jul 20, 2021
Fixing changelog using builtin type for a switch statement Fixing a possible panic scenario
ncabatoff
reviewed
Jul 22, 2021
hghaf099
commented
Jul 23, 2021
ncabatoff
reviewed
Jul 27, 2021
…mand, split the entries by commas
ncabatoff
reviewed
Aug 8, 2021
ncabatoff
approved these changes
Aug 8, 2021
jartek
pushed a commit
to jartek/vault
that referenced
this pull request
Sep 11, 2021
hashicorp#12126) * VAULT-2285 adding capability to accept comma separated entries for auth enable/tune * Adding changelog * Adding logic to detect invalid input parameter for auth enable config * Updating tune.mdx * Updating secret enable/tune for comma separated parameters * Adding further parameter checks for auth/secret tests Fixing changelog using builtin type for a switch statement Fixing a possible panic scenario * Changing a function name, using deep.Equal instead of what reflect package provides * Fixing auth/secret enable/tune mdx files * One more mdx file fix * Only when users provide a single comma separated string in a curl command, split the entries by commas * Fixing API docs for auth/mount enable/tune for comma separated entries * updating docs, removing an unnecessary switch case
briankassouf
deleted the
hghaf099-VAULT-2285-fix-headers-accept-comma-sep-ent
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…th enable/tune