Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VAULT-1303 when a request to vault fails, show namespace if set #12196

Merged
merged 5 commits into from Jul 30, 2021

Conversation

hghaf099
Copy link
Contributor

No description provided.

@vercel vercel bot temporarily deployed to Preview – vault July 28, 2021 23:11 Inactive
@vercel vercel bot temporarily deployed to Preview – vault-storybook July 28, 2021 23:11 Inactive
@vercel vercel bot temporarily deployed to Preview – vault July 29, 2021 14:33 Inactive
@vercel vercel bot temporarily deployed to Preview – vault-storybook July 29, 2021 14:33 Inactive
@vercel vercel bot temporarily deployed to Preview – vault-storybook July 29, 2021 18:44 Inactive
@vercel vercel bot temporarily deployed to Preview – vault July 29, 2021 18:44 Inactive
@hghaf099 hghaf099 requested a review from ncabatoff July 29, 2021 18:45
@hghaf099
Copy link
Contributor Author

I have also ran the new test I added in vault-ent to test this new functionality and it passes.

api/response.go Outdated Show resolved Hide resolved
Copy link
Contributor

@ncabatoff ncabatoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor change suggested, looks good overall, nice work!

@vercel vercel bot temporarily deployed to Preview – vault-storybook July 30, 2021 15:42 Inactive
@vercel vercel bot temporarily deployed to Preview – vault July 30, 2021 15:42 Inactive
@hghaf099 hghaf099 merged commit 6a8e377 into main Jul 30, 2021
jartek pushed a commit to jartek/vault that referenced this pull request Sep 11, 2021
…icorp#12196)

* VAULT-1303 when a request to vault fails, show namespace if set

* Adding changelog

* Fix Changelog file name

* Set namespace in ResponseWriter headers if it is set

* Using consts.NamespaceHeaderName instead of the literal string
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants