Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport 1.8.1: identity: do not allow a role's token_ttl to be longer than verificat… #12213

Merged
merged 2 commits into from
Jul 30, 2021

Commits on Jul 29, 2021

  1. identity: do not allow a role's token_ttl to be longer than verificat…

    …ion_ttl (#12151)
    
    * do not allow token_ttl to be longer than verification_ttl
    
    * add verification when updating an existing key
    
    When updating a key, ensure any roles referencing the key do not already
    have a token_ttl greater than the key's verification_ttl
    
    * add changelog
    
    * remove unneeded UT check and comment
    
    * refactor based on PR comments
    
    - remove make slice in favor of var delcaration
    - remove unneeded if check
    - validate expiry value during token generation
    - update changelog as bug
    
    * refactor get roles referencing target key names logic
    
    * add note about thread safety to helper func
    
    * update func comment
    
    * sort array and refactor func names
    
    * add warning to return response
    
    * remove unnecessary code from unit test
    
    * Update vault/identity_store_oidc.go
    
    Co-authored-by: Austin Gebauer <34121980+austingebauer@users.noreply.github.com>
    
    Co-authored-by: Austin Gebauer <34121980+austingebauer@users.noreply.github.com>
    2 people authored and calvn committed Jul 29, 2021
    Configuration menu
    Copy the full SHA
    024ec5e View commit details
    Browse the repository at this point in the history

Commits on Jul 30, 2021

  1. Configuration menu
    Copy the full SHA
    ec09b93 View commit details
    Browse the repository at this point in the history