Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update influxdb client #12262

Merged
merged 5 commits into from
Jan 25, 2022
Merged

Update influxdb client #12262

merged 5 commits into from
Jan 25, 2022

Conversation

tsaarni
Copy link
Contributor

@tsaarni tsaarni commented Aug 4, 2021 •
edited

Influxdb v1 client has been split into separate module from main influxdb code base. This change uses the correct client, which also allows us to get updates and avoids confusing some vuln scanners that flagged previous version incorrectly with vulnerabilities that applied only to the main code base.

Fixes #6088.

@tsaarni tsaarni requested a review from a team August 4, 2021 18:38
@vercel vercel bot temporarily deployed to Preview – vault August 4, 2021 18:38 Inactive
@vercel vercel bot temporarily deployed to Preview – vault-storybook August 4, 2021 18:38 Inactive
@tsaarni
Copy link
Contributor Author

tsaarni commented Aug 4, 2021

Note that this PR updates the current influxdb1 client to the correct library at https://github.com/influxdata/influxdb1-client.

Issue #12230 requests influxdb2 support, which would be https://github.com/influxdata/influxdb-client-go instead.

@pcman312 pcman312 added dependencies Pull requests that update a dependency file secret/database/influxdb labels Aug 17, 2021
@tsaarni
Update influxdb client
6629a68 
* Influxdb v1 client has been split into separate module from main influxdb
  code base. This changes uses the correct client, which also allows us to
  get updates and avoids confusing some vuln scanners that flagged previous
  version incorrectly with vulnerabilities. Fixes hashicorp#6088.
@vercel vercel bot temporarily deployed to Preview – vault-storybook August 17, 2021 17:33 Inactive
@vercel vercel bot temporarily deployed to Preview – vault August 17, 2021 17:33 Inactive
@tsaarni
Copy link
Contributor Author

tsaarni commented Aug 17, 2021

Updated the PR with missing changelog entry.

@vercel vercel bot temporarily deployed to Preview – vault October 1, 2021 12:28 Inactive
@vercel vercel bot temporarily deployed to Preview – vault-storybook October 1, 2021 12:28 Inactive
@erikgb
Copy link

erikgb commented Jan 24, 2022

We are seeing our image scanner triggering on this. Any chance to get this PR rebased, reviewed and merged?

@tsaarni
Copy link
Contributor Author

tsaarni commented Jan 24, 2022

I've merged main. @pmmukh would you happen to know if this PR could be reviewed and considered for merging to get rid of security alerts? Should be relatively trivial.

erikgb
erikgb approved these changes Jan 24, 2022
View reviewed changes
Copy link

@erikgb erikgb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@benashz benashz self-requested a review January 24, 2022 17:21
@benashz
Copy link
Contributor

benashz commented Jan 25, 2022 •
edited

Related tests are passing:

=== RUN   TestInfluxdb_Initialize
--- PASS: TestInfluxdb_Initialize (2.70s)
=== RUN   TestInfluxdb_Initialize/missing_config
    --- PASS: TestInfluxdb_Initialize/missing_config (0.00s)
=== RUN   TestInfluxdb_Initialize/port_is_an_int
    --- PASS: TestInfluxdb_Initialize/port_is_an_int (0.07s)
=== RUN   TestInfluxdb_Initialize/port_is_a_string
    --- PASS: TestInfluxdb_Initialize/port_is_a_string (0.00s)
=== RUN   TestInfluxdb_Initialize/missing_host
    --- PASS: TestInfluxdb_Initialize/missing_host (0.00s)
=== RUN   TestInfluxdb_Initialize/missing_username
    --- PASS: TestInfluxdb_Initialize/missing_username (0.00s)
=== RUN   TestInfluxdb_Initialize/missing_password
    --- PASS: TestInfluxdb_Initialize/missing_password (0.00s)
=== RUN   TestInfluxdb_Initialize/failed_to_validate_connection
    --- PASS: TestInfluxdb_Initialize/failed_to_validate_connection (0.01s)
=== RUN   TestInfluxdb_CreateUser_DefaultUsernameTemplate
--- PASS: TestInfluxdb_CreateUser_DefaultUsernameTemplate (2.31s)
=== RUN   TestInfluxdb_CreateUser_CustomUsernameTemplate
--- PASS: TestInfluxdb_CreateUser_CustomUsernameTemplate (2.35s)
=== RUN   TestUpdateUser_expiration
--- PASS: TestUpdateUser_expiration (2.46s)
=== RUN   TestUpdateUser_password
--- PASS: TestUpdateUser_password (3.80s)
=== RUN   TestInfluxdb_RevokeDeletedUser
--- PASS: TestInfluxdb_RevokeDeletedUser (2.91s)
=== RUN   TestInfluxdb_RevokeUser
--- PASS: TestInfluxdb_RevokeUser (2.97s)
PASS

Process finished with the exit code 0

@benashz benashz closed this Jan 25, 2022
@benashz benashz reopened this Jan 25, 2022
benashz
benashz approved these changes Jan 25, 2022
View reviewed changes
Copy link
Contributor

@benashz benashz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

changelog/12262.txt Outdated Show resolved Hide resolved
@benashz benashz self-requested a review January 25, 2022 16:18
benashz
benashz reviewed Jan 25, 2022
View reviewed changes
Copy link
Contributor

@benashz benashz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. Only a small update to the changelog stub.

@tsaarni @benashz
Update changelog/12262.txt
bbba8e8 
Co-authored-by: Ben Ash <32777270+benashz@users.noreply.github.com>
@vercel vercel bot temporarily deployed to Preview – vault-storybook January 25, 2022 16:20 Inactive
@tsaarni
Copy link
Contributor Author

tsaarni commented Jan 25, 2022

After applying the changelog update TestGauge_MaximumMeasurements failed. Does not appear to be influxdb related, possibly flaky test?

@benashz benashz merged commit 39dec80 into hashicorp:main Jan 25, 2022
@benashz
Copy link
Contributor

benashz commented Jan 25, 2022

After applying the changelog update TestGauge_MaximumMeasurements failed. Does not appear to be influxdb related, possibly flaky test?

Seems to be unrelated to this change. We'll look into thanks!

qk4l pushed a commit to qk4l/vault that referenced this pull request Feb 4, 2022
@tsaarni @benashz
Switch/upgrade to influxdata/influxdb1-client (hashicorp#12262)
e5a35c5 
* influxdb v1 client has been split into a separate module from the main influxdb
  code base. This changes uses the correct client, which also allows us to
  get updates and avoids confusing some vulnerability scanners that flagged 
  previous version incorrectly.

Co-authored-by: Ben Ash <32777270+benashz@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benashz benashz benashz approved these changes

@erikgb erikgb erikgb approved these changes

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file ecosystem secret/database/influxdb
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Switch influxdb client dependency to use github.com/influxdata/influxdb1-client
5 participants
@tsaarni @erikgb @benashz @pcman312 @pmmukh