Send x-forwarded-for in Okta Push Factor request #12320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Why: In order for Okta to properly report the location of the authentication attempt, the X-Forwarded-For header must be included in the request to Okta (if it exists). This change addresses the need by: * Duplicating the value of X-Forwarded-For if it's passed through to the auth backend
rbhitchcock
force-pushed
the
rbhitchcock.12319.okta-verify-x-forwarded-for
branch
from
fd7bf52
to
e656c8e
Compare
|
The failing test appears to be an error in Circle CI unrelated to this change, but please let me know if I am mistaken on that. |
No, you're correct - we have a few tests that get a little squirrelly. I'm kicking them, and we'll get this sorted soon! :) |
hsimon-hashicorp
approved these changes
Sep 3, 2021
jartek
pushed a commit
to jartek/vault
that referenced
this pull request
Sep 11, 2021
* Send x-forwarded-for in Okta Push Factor request Why: In order for Okta to properly report the location of the authentication attempt, the X-Forwarded-For header must be included in the request to Okta (if it exists). This change addresses the need by: * Duplicating the value of X-Forwarded-For if it's passed through to the auth backend * Add changelog entry for 12320
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why:
In order for Okta to properly report the location of the authentication
attempt, the X-Forwarded-For header must be included in the request to
Okta (if it exists).
This change addresses the need by:
auth backend
Fixes #12319