(OSS Port) Restrict Quota Deletion to Primary Cluster [vault-2399] #12339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vishalnayak
reviewed
Aug 17, 2021
vishalnayak
approved these changes
Aug 17, 2021
Co-authored-by: Vishal Nayak <vishalnayak@users.noreply.github.com>
jartek
pushed a commit
to jartek/vault
that referenced
this pull request
Sep 11, 2021
…ashicorp#12339) * oss part of vault 2399 * Update vault/quotas/quotas.go Co-authored-by: Vishal Nayak <vishalnayak@users.noreply.github.com> * use OSS PR number as changelog entry as indicated by the changelog guide Co-authored-by: Vishal Nayak <vishalnayak@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ent testing: https://github.com/hashicorp/vault-enterprise/pull/2051/files
Description: This PR restricts quota deletion when an auth backend is removed to the primary cluster only. The PR above has a test that verifies the bug with quota deletion does not occur when secrets backends are deleted. We do not need to check if the cluster is a DR cluster, as DR clusters cannot utilize the quota deletion path or disable auth paths. Therefore, the bug doesn't show up in those areas.