New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade pq to fix connection failure cleanup bug (v1.8.0 => v1.10.3) #12413
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| ```release-note:bug | ||
| storage/postgres: Update postgres library (github.com/lib/pq) to properly remove terminated TLS connections from the connection pool. | ||
| database/postgres: Update postgres library (github.com/lib/pq) to properly remove terminated TLS connections from the connection pool. | ||
| ``` |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks unrelated to the dep updates. Can we rebase/merge
origin/mainonce more? I just merged a PR that synced up the deps recently which should take this change out of the PR.I don't see other deps being pulled in, but can we do the dep update without the
-uoption just in case, so that we don't end up pulling transitive dep updates?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This came from running
go mod tidyand occurs on the head of main still for me:I can rewrite the commits to drop the
go mod tidybut had added that call based on this comment's suggestion: #12413 (comment)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's okay. It's just removing the older checksum format for the
github.com/hashicorp/vault-plugin-auth-kubernetespackage. You can see the latest version of the plugin that's in use remains just below these changes with the sameQ13bq4paoPWW+bsSq2seyiLPQkFl5vrb+vIwwLDlQ8M=value:There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What version of
goare you on?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it is honoring the go1.16 directive in the go.mod file and not making 2 requires blocks ala 1.17 -- if it is an issue let me know and I'll remove commit d43574b
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, we should be running
go mod tidy. It's odd that this removal didn't apply already in my recently commit which I also rango mod tidyagainst. I was hoping to clean this up so that it'd make backporting and conflict resolution a little easier, but we can also address this on our end.Can we also include a changelog file that mentions the bug fix as part of this PR? Here is a sample of the formatting for a changelog entry file (the name of the file should be the PR number). Something along the lines of:
Sorry for the numerous back-and-forths on this!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added
changelog/12413.txtin 2b37f57