Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose secret_id_accessor as WrappedAccessor when wrapping secret-id creation. #12425

Merged
merged 6 commits into from Sep 16, 2021
Merged

Expose secret_id_accessor as WrappedAccessor when wrapping secret-id creation. #12425

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
9a9702c
Expose secret_id_accessor as WrappedAccessor when wrapping secret-id …
melbit-michaelw Aug 25, 2021
60b6ec2
Add changelog.
melbit-michaelw Aug 25, 2021
bcf7ea5
Minor updates as suggested.
melbit-michaelw Sep 9, 2021
0c72ec0
Adding external test for wrapped accessor.
melbit-michaelw Sep 9, 2021
5b5db2b
Add check that mounttype is approle.
melbit-michaelw Sep 15, 2021
18afb6d
Update changelog text to use improvement
melbit-michaelw Sep 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 3 additions & 0 deletions changelog/12425.txt
View file
Open in desktop
@@ -0,0 +1,3 @@
```release-note:enhancement
auth/approle: expose secret_id_accessor as WrappedAccessor when creating wrapped secret-id.
```
5 changes: 5 additions & 0 deletions vault/wrapping.go
View file
Open in desktop
Expand Up @@ -184,6 +184,11 @@ DONELISTHANDLING:
resp.WrapInfo.WrappedAccessor = resp.Auth.Accessor
}

// Make secret_id_accessor available as a WrappedAccessor.
melbit-michaelw marked this conversation as resolved.
Show resolved Hide resolved
if secretIdAccessor, ok := resp.Data["secret_id_accessor"]; ok {
melbit-michaelw marked this conversation as resolved.
Show resolved Hide resolved
resp.WrapInfo.WrappedAccessor = secretIdAccessor.(string)
}

switch resp.WrapInfo.Format {
case "jwt":
// Create the JWT
Expand Down